Open
Conversation
stephenliang
approved these changes
May 7, 2026
Comment on lines
+52
to
54
| "react": "18", | ||
| "react-dom": "18", | ||
| "react-papaparse": "^3.8.0", |
Member
There was a problem hiding this comment.
These are exact pins, which we shouldn't use. Although not necessarily important because when we bring it to frontend, we'd use the catalog version instead. I'd prefer we use a more relaxed semver, but I leave that up to you if we are going to inline to the main repo soon.
| return () => { | ||
| clearInterval(animationTimer); | ||
| }; | ||
| }, []); // eslint-disable-line react-hooks/exhaustive-deps |
Member
There was a problem hiding this comment.
nit: Comment why or refactor to avoid?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fairly straight-forward conversion. Though it chose to make them in the form
function MyComponent(...) {}and I would preferconst MyComponent = ({...}: MyComponentProps) => {...}instead. I will convert this in the TypeScript path.